lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 861/879] net: ipa: fix page free in ipa_endpoint_trans_release()
    Date
    From: Alex Elder <elder@linaro.org>

    commit 155c0c90bca918de6e4327275dfc1d97fd604115 upstream.

    Currently the (possibly compound) page used for receive buffers are
    freed using __free_pages(). But according to this comment above the
    definition of that function, that's wrong:
    If you want to use the page's reference count to decide when
    to free the allocation, you should allocate a compound page,
    and use put_page() instead of __free_pages().

    Convert the call to __free_pages() in ipa_endpoint_trans_release()
    to use put_page() instead.

    Fixes: ed23f02680caa ("net: ipa: define per-endpoint receive buffer size")
    Signed-off-by: Alex Elder <elder@linaro.org>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ipa/ipa_endpoint.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    --- a/drivers/net/ipa/ipa_endpoint.c
    +++ b/drivers/net/ipa/ipa_endpoint.c
    @@ -1385,11 +1385,8 @@ void ipa_endpoint_trans_release(struct i
    } else {
    struct page *page = trans->data;

    - if (page) {
    - u32 buffer_size = endpoint->data->rx.buffer_size;
    -
    - __free_pages(page, get_order(buffer_size));
    - }
    + if (page)
    + put_page(page);
    }
    }


    \
     
     \ /
      Last update: 2022-06-08 04:50    [W:3.454 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site