lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 862/879] net: ipa: fix page free in ipa_endpoint_replenish_one()
    Date
    From: Alex Elder <elder@linaro.org>

    commit 70132763d5d2e94cd185e3aa92ac6a3ba89068fa upstream.

    Currently the (possibly compound) pages used for receive buffers are
    freed using __free_pages(). But according to this comment above the
    definition of that function, that's wrong:
    If you want to use the page's reference count to decide
    when to free the allocation, you should allocate a compound
    page, and use put_page() instead of __free_pages().

    Convert the call to __free_pages() in ipa_endpoint_replenish_one()
    to use put_page() instead.

    Fixes: 6a606b90153b8 ("net: ipa: allocate transaction in replenish loop")
    Signed-off-by: Alex Elder <elder@linaro.org>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ipa/ipa_endpoint.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ipa/ipa_endpoint.c
    +++ b/drivers/net/ipa/ipa_endpoint.c
    @@ -1062,7 +1062,7 @@ static int ipa_endpoint_replenish_one(st

    ret = gsi_trans_page_add(trans, page, len, offset);
    if (ret)
    - __free_pages(page, get_order(buffer_size));
    + put_page(page);
    else
    trans->data = page; /* transaction owns page now */


    \
     
     \ /
      Last update: 2022-06-08 04:50    [W:3.611 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site