Messages in this thread | | | Date | Tue, 7 Jun 2022 22:30:28 +0200 (CEST) | From | Richard Weinberger <> | Subject | Re: [PATCH 2/2] mtdchar: use kvmalloc() for potentially large allocations |
| |
----- Ursprüngliche Mail ----- > Von: "Michał Kępień" <kernel@kempniu.pl> > An: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com> > CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org> > Gesendet: Montag, 16. Mai 2022 09:06:01 > Betreff: [PATCH 2/2] mtdchar: use kvmalloc() for potentially large allocations
> mtdchar_write_ioctl() calls kmalloc() with the 'size' argument set to > the smaller of two values: the write request's data/OOB length provided > by user space and the erase block size of the MTD device. If the latter > is large, kmalloc() may not be able to serve such allocation requests. > Use kvmalloc() instead. Correspondingly, replace kfree() calls with > kvfree() calls. > > Suggested-by: Richard Weinberger <richard@nod.at> > Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Looks good to me. Acked-by: Richard Weinberger <richard@nod.at>
Thanks, //richard
| |