lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 724/879] ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit a508e33956b538e034ed5df619a73ec7c15bda72 upstream.

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 00d93611f002 ("ipmi:ipmb: Add the ability to have a separate slave and master device")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Message-Id: <20220512044445.3102-1-linmq006@gmail.com>
    Cc: stable@vger.kernel.org # v5.17+
    Signed-off-by: Corey Minyard <cminyard@mvista.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/ipmi/ipmi_ipmb.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/char/ipmi/ipmi_ipmb.c
    +++ b/drivers/char/ipmi/ipmi_ipmb.c
    @@ -476,6 +476,7 @@ static int ipmi_ipmb_probe(struct i2c_cl
    slave_np = of_parse_phandle(dev->of_node, "slave-dev", 0);
    if (slave_np) {
    slave_adap = of_get_i2c_adapter_by_node(slave_np);
    + of_node_put(slave_np);
    if (!slave_adap) {
    dev_notice(&client->dev,
    "Could not find slave adapter\n");

    \
     
     \ /
      Last update: 2022-06-08 03:46    [W:3.317 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site