lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 501/879] platform/x86: intel_cht_int33fe: Set driver data
    Date
    From: Heikki Krogerus <heikki.krogerus@linux.intel.com>

    [ Upstream commit 3ce827bf9cfecaf2cbfd9a9d44f0db9f40882780 ]

    Module removal fails because cht_int33fe_typec_remove()
    tries to access driver data that does not exist. Fixing by
    assigning the data at the end of probe.

    Fixes: 915623a80b5a ("platform/x86: intel_cht_int33fe: Switch to DMI modalias based loading")
    Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Link: https://lore.kernel.org/r/20220519122103.78546-1-heikki.krogerus@linux.intel.com
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/intel/chtwc_int33fe.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/platform/x86/intel/chtwc_int33fe.c b/drivers/platform/x86/intel/chtwc_int33fe.c
    index 0de509fbf020..c52ac23e2331 100644
    --- a/drivers/platform/x86/intel/chtwc_int33fe.c
    +++ b/drivers/platform/x86/intel/chtwc_int33fe.c
    @@ -389,6 +389,8 @@ static int cht_int33fe_typec_probe(struct platform_device *pdev)
    goto out_unregister_fusb302;
    }

    + platform_set_drvdata(pdev, data);
    +
    return 0;

    out_unregister_fusb302:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 03:43    [W:3.545 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site