lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 868/879] binder: fix sender_euid type in uapi header
    Date
    From: Carlos Llamas <cmllamas@google.com>

    commit 8cc5b032240ae5220b62c689c20459d3e1825b2d upstream.

    The {pid,uid}_t fields of struct binder_transaction were recently
    replaced to use kernel types in commit 169adc2b6b3c ("android/binder.h:
    add linux/android/binder(fs).h to UAPI compile-test coverage").

    However, using __kernel_uid_t here breaks backwards compatibility in
    architectures using 16-bits for this type, since glibc and some others
    still expect a 32-bit uid_t. Instead, let's use __kernel_uid32_t which
    avoids this compatibility problem.

    Fixes: 169adc2b6b3c ("android/binder.h: add linux/android/binder(fs).h to UAPI compile-test coverage")
    Reported-by: Christopher Ferris <cferris@google.com>
    Signed-off-by: Carlos Llamas <cmllamas@google.com>
    Acked-by: Todd Kjos <tkjos@google.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/uapi/linux/android/binder.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/uapi/linux/android/binder.h
    +++ b/include/uapi/linux/android/binder.h
    @@ -289,7 +289,7 @@ struct binder_transaction_data {
    /* General information about the transaction. */
    __u32 flags;
    __kernel_pid_t sender_pid;
    - __kernel_uid_t sender_euid;
    + __kernel_uid32_t sender_euid;
    binder_size_t data_size; /* number of bytes of data */
    binder_size_t offsets_size; /* number of bytes of offsets */


    \
     
     \ /
      Last update: 2022-06-08 03:42    [W:2.033 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site