lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 634/879] hwrng: omap3-rom - fix using wrong clk_disable() in omap_rom_rng_runtime_resume()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit e4e62bbc6aba49a5edb3156ec65f6698ff37d228 ]

    'ddata->clk' is enabled by clk_prepare_enable(), it should be disabled
    by clk_disable_unprepare().

    Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom functions")
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/char/hw_random/omap3-rom-rng.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c
    index e0d77fa048fb..f06e4f95114f 100644
    --- a/drivers/char/hw_random/omap3-rom-rng.c
    +++ b/drivers/char/hw_random/omap3-rom-rng.c
    @@ -92,7 +92,7 @@ static int __maybe_unused omap_rom_rng_runtime_resume(struct device *dev)

    r = ddata->rom_rng_call(0, 0, RNG_GEN_PRNG_HW_INIT);
    if (r != 0) {
    - clk_disable(ddata->clk);
    + clk_disable_unprepare(ddata->clk);
    dev_err(dev, "HW init failed: %d\n", r);

    return -EIO;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 03:41    [W:3.917 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site