lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 584/879] mfd: ipaq-micro: Fix error check return value of platform_get_irq()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit 3b49ae380ce1a3054e0c505dd9a356b82a5b48e8 ]

    platform_get_irq() return negative value on failure, so null check of
    irq is incorrect. Fix it by comparing whether it is less than zero.

    Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Link: https://lore.kernel.org/r/20220412085305.2533030-1-lv.ruyi@zte.com.cn
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/ipaq-micro.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
    index e92eeeb67a98..4cd5ecc72211 100644
    --- a/drivers/mfd/ipaq-micro.c
    +++ b/drivers/mfd/ipaq-micro.c
    @@ -403,7 +403,7 @@ static int __init micro_probe(struct platform_device *pdev)
    micro_reset_comm(micro);

    irq = platform_get_irq(pdev, 0);
    - if (!irq)
    + if (irq < 0)
    return -EINVAL;
    ret = devm_request_irq(&pdev->dev, irq, micro_serial_isr,
    IRQF_SHARED, "ipaq-micro",
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 03:41    [W:5.920 / U:1.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site