lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 536/879] memory: samsung: exynos5422-dmc: Avoid some over memory allocation
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 56653827f0d7bc7c2d8bac0e119fd1521fa9990a ]

    'dmc->counter' is a 'struct devfreq_event_dev **', so there is some
    over memory allocation. 'counters_size' should be computed with
    'sizeof(struct devfreq_event_dev *)'.

    Use 'sizeof(*dmc->counter)' instead to fix it.

    While at it, use devm_kcalloc() instead of devm_kzalloc()+open coded
    multiplication.

    Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/69d7e69346986e2fdb994d4382954c932f9f0993.1647760213.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/samsung/exynos5422-dmc.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
    index 9c8318923ed0..4733e7898ffe 100644
    --- a/drivers/memory/samsung/exynos5422-dmc.c
    +++ b/drivers/memory/samsung/exynos5422-dmc.c
    @@ -1322,7 +1322,6 @@ static int exynos5_dmc_init_clks(struct exynos5_dmc *dmc)
    */
    static int exynos5_performance_counters_init(struct exynos5_dmc *dmc)
    {
    - int counters_size;
    int ret, i;

    dmc->num_counters = devfreq_event_get_edev_count(dmc->dev,
    @@ -1332,8 +1331,8 @@ static int exynos5_performance_counters_init(struct exynos5_dmc *dmc)
    return dmc->num_counters;
    }

    - counters_size = sizeof(struct devfreq_event_dev) * dmc->num_counters;
    - dmc->counter = devm_kzalloc(dmc->dev, counters_size, GFP_KERNEL);
    + dmc->counter = devm_kcalloc(dmc->dev, dmc->num_counters,
    + sizeof(*dmc->counter), GFP_KERNEL);
    if (!dmc->counter)
    return -ENOMEM;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 03:40    [W:3.020 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site