lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 849/879] phy: qcom-qmp: fix struct clk leak on probe errors
    Date
    From: Johan Hovold <johan+linaro@kernel.org>

    commit f0a4bc38a12f5a0cc5ad68670d9480e91e6a94df upstream.

    Make sure to release the pipe clock reference in case of a late probe
    error (e.g. probe deferral).

    Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
    Cc: stable@vger.kernel.org # 4.12
    Cc: Vivek Gautam <vivek.gautam@codeaurora.org>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    Link: https://lore.kernel.org/r/20220427063243.32576-2-johan+linaro@kernel.org
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
    +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
    @@ -5890,7 +5890,7 @@ int qcom_qmp_phy_create(struct device *d
    * all phys that don't need this.
    */
    snprintf(prop_name, sizeof(prop_name), "pipe%d", id);
    - qphy->pipe_clk = of_clk_get_by_name(np, prop_name);
    + qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);
    if (IS_ERR(qphy->pipe_clk)) {
    if (cfg->type == PHY_TYPE_PCIE ||
    cfg->type == PHY_TYPE_USB3) {

    \
     
     \ /
      Last update: 2022-06-08 03:40    [W:5.763 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site