lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 720/879] iwlwifi: fw: init SAR GEO table only if data is present
    Date
    From: Johannes Berg <johannes.berg@intel.com>

    commit d1f6530c3e373ddd7c76b05646052a27eead14ad upstream.

    When no table data was read from ACPI, then filling the data
    and returning success here will fill zero values, which means
    transmit power will be limited to 0 dBm. This is clearly not
    intended.

    Return an error from iwl_sar_geo_init() if there's no data to
    fill into the command structure.

    Cc: stable@vger.kernel.org
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Fixes: 78a19d5285d9 ("iwlwifi: mvm: Read the PPAG and SAR tables at INIT stage")
    Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
    Link: https://lore.kernel.org/r/20220517120044.bc45923b74e9.Id2b4362234b7f8ced82c591b95d4075dd2ec12f4@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
    +++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
    @@ -937,6 +937,9 @@ int iwl_sar_geo_init(struct iwl_fw_runti
    {
    int i, j;

    + if (!fwrt->geo_enabled)
    + return -ENODATA;
    +
    if (!iwl_sar_geo_support(fwrt))
    return -EOPNOTSUPP;


    \
     
     \ /
      Last update: 2022-06-08 03:36    [W:4.021 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site