lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 484/879] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit c56de483093d7ad0782327f95dda7da97bc4c315 ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.

    a6xx_gmu_init() passes the node to of_find_device_by_node()
    and of_dma_configure(), of_find_device_by_node() will takes its
    reference, of_dma_configure() doesn't need the node after usage.

    Add missing of_node_put() to avoid refcount leak.

    Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
    Link: https://lore.kernel.org/r/20220512121955.56937-1-linmq006@gmail.com
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
    index ccc4fcf7a630..a8f6d73197b1 100644
    --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
    +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
    @@ -1919,6 +1919,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
    BUG_ON(!node);

    ret = a6xx_gmu_init(a6xx_gpu, node);
    + of_node_put(node);
    if (ret) {
    a6xx_destroy(&(a6xx_gpu->base.base));
    return ERR_PTR(ret);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 03:36    [W:2.615 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site