lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 599/879] firmware: arm_ffa: Remove incorrect assignment of driver_data
    Date
    From: Sudeep Holla <sudeep.holla@arm.com>

    [ Upstream commit 00512d2930b338fdd42bd90bbd1793fe212c2d31 ]

    The ffa core driver currently assigns its own driver information
    to individual ffa device driver_data which is wrong. Firstly, it leaks
    this core driver information to individual ffa_device and hence to
    ffa_driver. Secondly the ffa_device driver_data is for use by individual
    ffa_driver and not for this core driver managing all those devices.

    Link: https://lore.kernel.org/r/20220429113946.2087145-2-sudeep.holla@arm.com
    Fixes: d0c0bce83122 ("firmware: arm_ffa: Setup in-kernel users of FFA partitions")
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/arm_ffa/driver.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c
    index 8fa1785afd42..44300dbcc643 100644
    --- a/drivers/firmware/arm_ffa/driver.c
    +++ b/drivers/firmware/arm_ffa/driver.c
    @@ -688,8 +688,6 @@ static void ffa_setup_partitions(void)
    __func__, tpbuf->id);
    continue;
    }
    -
    - ffa_dev_set_drvdata(ffa_dev, drv_info);
    }
    kfree(pbuf);
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 03:33    [W:2.494 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site