lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 447/879] media: make RADIO_ADAPTERS tristate
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 215d49a41709610b9e82a49b27269cfaff1ef0b6 ]

    Fix build errors when RADIO_TEA575X=y, VIDEO_BT848=m, and VIDEO_DEV=m.

    The build errors occur due to [in drivers/media/Makefile]:
    obj-$(CONFIG_VIDEO_DEV) += radio/
    so the (would be) builtin tea575x.o is not being built.

    This is also due to drivers/media/radio/Kconfig declaring a bool
    Kconfig symbol (RADIO_ADAPTERS) that depends on a tristate (VIDEO_DEV),
    so when VIDEO_DEV=m, RADIO_ADAPTERS becomes =y, and then the drivers
    that depend on RADIO_ADPATERS can be configured as builtin (=y) or
    as loadable modules (=m).

    Fix this by converting RADIO_ADAPTERS to a tristate symbol instead
    of a bool symbol.

    Fixes these build errors:

    ERROR: modpost: "snd_tea575x_hw_init" [drivers/media/pci/bt8xx/bttv.ko] undefined!
    ERROR: modpost: "snd_tea575x_set_freq" [drivers/media/pci/bt8xx/bttv.ko] undefined!
    ERROR: modpost: "snd_tea575x_s_hw_freq_seek" [drivers/media/pci/bt8xx/bttv.ko] undefined!
    ERROR: modpost: "snd_tea575x_enum_freq_bands" [drivers/media/pci/bt8xx/bttv.ko] undefined!
    ERROR: modpost: "snd_tea575x_g_tuner" [drivers/media/pci/bt8xx/bttv.ko] undefined!

    Link: lore.kernel.org/r/202204191711.IKJJFjgU-lkp@intel.com

    Fixes: 9958d30f38b9 ("media: Kconfig: cleanup VIDEO_DEV dependencies")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/radio/Kconfig | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
    index cca03bd2cc42..616a38feb641 100644
    --- a/drivers/media/radio/Kconfig
    +++ b/drivers/media/radio/Kconfig
    @@ -4,10 +4,10 @@
    #

    menuconfig RADIO_ADAPTERS
    - bool "Radio Adapters"
    + tristate "Radio Adapters"
    depends on VIDEO_DEV
    depends on MEDIA_RADIO_SUPPORT
    - default y
    + default VIDEO_DEV
    help
    Say Y here to enable selecting AM/FM radio adapters.

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 02:19    [W:2.291 / U:0.788 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site