lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 444/879] media: i2c: rdacm2x: properly set subdev entity function
    Date
    From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

    [ Upstream commit d2facee67b4883bb3e7461a0a93fd70d0c7b7261 ]

    The subdevice entity function was left unset, which produces a warning
    when probing the device:

    mxc-md bus@58000000:camera: Entity type for entity rdacm20 19-0051 was
    not initialized!

    This patch will set entity function to MEDIA_ENT_F_CAM_SENSOR and leave
    flags unset.

    Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver")
    Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
    Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
    Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/rdacm20.c | 2 +-
    drivers/media/i2c/rdacm21.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
    index 025a610de893..9c6f66cab564 100644
    --- a/drivers/media/i2c/rdacm20.c
    +++ b/drivers/media/i2c/rdacm20.c
    @@ -611,7 +611,7 @@ static int rdacm20_probe(struct i2c_client *client)
    goto error_free_ctrls;

    dev->pad.flags = MEDIA_PAD_FL_SOURCE;
    - dev->sd.entity.flags |= MEDIA_ENT_F_CAM_SENSOR;
    + dev->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
    ret = media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
    if (ret < 0)
    goto error_free_ctrls;
    diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
    index 12ec5467ed1e..ef31cf5f23ca 100644
    --- a/drivers/media/i2c/rdacm21.c
    +++ b/drivers/media/i2c/rdacm21.c
    @@ -583,7 +583,7 @@ static int rdacm21_probe(struct i2c_client *client)
    goto error_free_ctrls;

    dev->pad.flags = MEDIA_PAD_FL_SOURCE;
    - dev->sd.entity.flags |= MEDIA_ENT_F_CAM_SENSOR;
    + dev->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
    ret = media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
    if (ret < 0)
    goto error_free_ctrls;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 02:19    [W:4.109 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site