lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 388/879] irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value
    Date
    From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    [ Upstream commit 50f0f26e7c8665763d0d7d3372dbcf191f94d077 ]

    The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.

    Fixes: f48e699ddf70 ("irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed")
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20220423094227.33148-1-krzysztof.kozlowski@linaro.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/irqchip/irq-aspeed-i2c-ic.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c b/drivers/irqchip/irq-aspeed-i2c-ic.c
    index a47db16ff960..9c9fc3e2967e 100644
    --- a/drivers/irqchip/irq-aspeed-i2c-ic.c
    +++ b/drivers/irqchip/irq-aspeed-i2c-ic.c
    @@ -77,8 +77,8 @@ static int __init aspeed_i2c_ic_of_init(struct device_node *node,
    }

    i2c_ic->parent_irq = irq_of_parse_and_map(node, 0);
    - if (i2c_ic->parent_irq < 0) {
    - ret = i2c_ic->parent_irq;
    + if (!i2c_ic->parent_irq) {
    + ret = -EINVAL;
    goto err_iounmap;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:43    [W:4.890 / U:1.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site