lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 380/879] kunit: fix debugfs code to use enum kunit_status, not bool
    Date
    From: Daniel Latypov <dlatypov@google.com>

    [ Upstream commit 38289a26e1b8a37755f3e07056ca416c1ee2a2e8 ]

    Commit 6d2426b2f258 ("kunit: Support skipped tests") switched to using
    `enum kunit_status` to track the result of running a test/suite since we
    now have more than just pass/fail.

    This callsite wasn't updated, silently converting to enum to a bool and
    then back.

    Fixes: 6d2426b2f258 ("kunit: Support skipped tests")
    Signed-off-by: Daniel Latypov <dlatypov@google.com>
    Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/kunit/debugfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lib/kunit/debugfs.c b/lib/kunit/debugfs.c
    index b71db0abc12b..1048ef1b8d6e 100644
    --- a/lib/kunit/debugfs.c
    +++ b/lib/kunit/debugfs.c
    @@ -52,7 +52,7 @@ static void debugfs_print_result(struct seq_file *seq,
    static int debugfs_print_results(struct seq_file *seq, void *v)
    {
    struct kunit_suite *suite = (struct kunit_suite *)seq->private;
    - bool success = kunit_suite_has_succeeded(suite);
    + enum kunit_status success = kunit_suite_has_succeeded(suite);
    struct kunit_case *test_case;

    if (!suite || !suite->log)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:43    [W:4.023 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site