lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 233/879] ARM: hisi: Add missing of_node_put after of_find_compatible_node
    Date
    From: Peng Wu <wupeng58@huawei.com>

    [ Upstream commit 9bc72e47d4630d58a840a66a869c56b29554cfe4 ]

    of_find_compatible_node will increment the refcount of the returned
    device_node. Calling of_node_put() to avoid the refcount leak

    Signed-off-by: Peng Wu <wupeng58@huawei.com>
    Signed-off-by: Wei Xu <xuwei5@hisilicon.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/mach-hisi/platsmp.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
    index a56cc64deeb8..9ce93e0b6cdc 100644
    --- a/arch/arm/mach-hisi/platsmp.c
    +++ b/arch/arm/mach-hisi/platsmp.c
    @@ -67,14 +67,17 @@ static void __init hi3xxx_smp_prepare_cpus(unsigned int max_cpus)
    }
    ctrl_base = of_iomap(np, 0);
    if (!ctrl_base) {
    + of_node_put(np);
    pr_err("failed to map address\n");
    return;
    }
    if (of_property_read_u32(np, "smp-offset", &offset) < 0) {
    + of_node_put(np);
    pr_err("failed to find smp-offset property\n");
    return;
    }
    ctrl_base += offset;
    + of_node_put(np);
    }
    }

    @@ -160,6 +163,7 @@ static int hip01_boot_secondary(unsigned int cpu, struct task_struct *idle)
    if (WARN_ON(!node))
    return -1;
    ctrl_base = of_iomap(node, 0);
    + of_node_put(node);

    /* set the secondary core boot from DDR */
    remap_reg_value = readl_relaxed(ctrl_base + REG_SC_CTRL);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:33    [W:2.162 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site