lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 256/879] drm/omap: fix NULL but dereferenced coccicheck error
    Date
    From: Wan Jiabing <wanjiabing@vivo.com>

    [ Upstream commit 8f2a3970c969d0d8d7289a4c65edcedafc16fd92 ]

    Fix the following coccicheck warning:
    ./drivers/gpu/drm/omapdrm/omap_overlay.c:89:22-25: ERROR: r_ovl is NULL
    but dereferenced.

    Here should be ovl->idx rather than r_ovl->idx.

    Fixes: e02b5cc9e898ad ("drm/omap: Add a 'right overlay' to plane state")
    Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220307095612.409090-1-wanjiabing@vivo.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/omapdrm/omap_overlay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/omapdrm/omap_overlay.c b/drivers/gpu/drm/omapdrm/omap_overlay.c
    index 10730c9b2752..b0bc9ad2ef73 100644
    --- a/drivers/gpu/drm/omapdrm/omap_overlay.c
    +++ b/drivers/gpu/drm/omapdrm/omap_overlay.c
    @@ -86,7 +86,7 @@ int omap_overlay_assign(struct drm_atomic_state *s, struct drm_plane *plane,
    r_ovl = omap_plane_find_free_overlay(s->dev, overlay_map,
    caps, fourcc);
    if (!r_ovl) {
    - overlay_map[r_ovl->idx] = NULL;
    + overlay_map[ovl->idx] = NULL;
    *overlay = NULL;
    return -ENOMEM;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:24    [W:4.303 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site