lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 227/879] fat: add ratelimit to fat*_ent_bread()
    Date
    From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

    [ Upstream commit 183c3237c928109d2008c0456dff508baf692b20 ]

    fat*_ent_bread() can be the cause of too many report on I/O error path.
    So use fat_msg_ratelimit() instead.

    Link: https://lkml.kernel.org/r/87bkxogfeq.fsf@mail.parknet.co.jp
    Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    Reported-by: qianfan <qianfanguijin@163.com>
    Tested-by: qianfan <qianfanguijin@163.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/fat/fatent.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
    index 978ac6751aeb..1db348f8f887 100644
    --- a/fs/fat/fatent.c
    +++ b/fs/fat/fatent.c
    @@ -94,7 +94,8 @@ static int fat12_ent_bread(struct super_block *sb, struct fat_entry *fatent,
    err_brelse:
    brelse(bhs[0]);
    err:
    - fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)", (llu)blocknr);
    + fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)",
    + (llu)blocknr);
    return -EIO;
    }

    @@ -107,8 +108,8 @@ static int fat_ent_bread(struct super_block *sb, struct fat_entry *fatent,
    fatent->fat_inode = MSDOS_SB(sb)->fat_inode;
    fatent->bhs[0] = sb_bread(sb, blocknr);
    if (!fatent->bhs[0]) {
    - fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)",
    - (llu)blocknr);
    + fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)",
    + (llu)blocknr);
    return -EIO;
    }
    fatent->nr_bhs = 1;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:22    [W:2.861 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site