lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 120/879] drm: msm: fix error check return value of irq_of_parse_and_map()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit b9e4f1d2b505df8e2439b63e67afaa287c1c43e2 ]

    The irq_of_parse_and_map() function returns 0 on failure, and does not
    return an negative value.

    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Patchwork: https://patchwork.freedesktop.org/patch/483175/
    Link: https://lore.kernel.org/r/20220424031959.3172406-1-lv.ruyi@zte.com.cn
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
    index 3b92372e7bdf..1d4bbde29320 100644
    --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
    +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
    @@ -570,9 +570,9 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
    }

    irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
    - if (irq < 0) {
    - ret = irq;
    - DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
    + if (!irq) {
    + ret = -EINVAL;
    + DRM_DEV_ERROR(&pdev->dev, "failed to get irq\n");
    goto fail;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:12    [W:2.112 / U:1.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site