lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 117/879] drm/amd/pm: fix the compile warning
    Date
    From: Evan Quan <evan.quan@amd.com>

    [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ]

    Fix the compile warning below:
    drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641
    kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)'

    Reported-by: kernel test robot <lkp@intel.com>
    CC: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 14 +-------------
    1 file changed, 1 insertion(+), 13 deletions(-)

    diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
    index 8b23cc9f098a..8fd0782a2b20 100644
    --- a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
    +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
    @@ -1623,19 +1623,7 @@ static int kv_update_samu_dpm(struct amdgpu_device *adev, bool gate)

    static u8 kv_get_acp_boot_level(struct amdgpu_device *adev)
    {
    - u8 i;
    - struct amdgpu_clock_voltage_dependency_table *table =
    - &adev->pm.dpm.dyn_state.acp_clock_voltage_dependency_table;
    -
    - for (i = 0; i < table->count; i++) {
    - if (table->entries[i].clk >= 0) /* XXX */
    - break;
    - }
    -
    - if (i >= table->count)
    - i = table->count - 1;
    -
    - return i;
    + return 0;
    }

    static void kv_update_acp_boot_level(struct amdgpu_device *adev)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:12    [W:2.216 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site