lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 109/879] scsi: megaraid: Fix error check return value of register_chrdev()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit c5acd61dbb32b6bda0f3a354108f2b8dcb788985 ]

    If major equals 0, register_chrdev() returns an error code when it fails.
    This function dynamically allocates a major and returns its number on
    success, so we should use "< 0" to check it instead of "!".

    Link: https://lore.kernel.org/r/20220418105755.2558828-1-lv.ruyi@zte.com.cn
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/megaraid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
    index a5d8cee2d510..bf491af9f0d6 100644
    --- a/drivers/scsi/megaraid.c
    +++ b/drivers/scsi/megaraid.c
    @@ -4607,7 +4607,7 @@ static int __init megaraid_init(void)
    * major number allocation.
    */
    major = register_chrdev(0, "megadev_legacy", &megadev_fops);
    - if (!major) {
    + if (major < 0) {
    printk(KERN_WARNING
    "megaraid: failed to register char device\n");
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:12    [W:2.369 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site