Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 7 Jun 2022 11:49:57 -0700 | Subject | Re: [PATCH] net/bluetooth: fix erroneous use of bitmap_from_u64() |
| |
On Mon, Jun 6, 2022 at 11:00 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Right, thanks for fixing it. About some of the changes perhaps we > should use BIT when declaring values in enum hci_conn_flags?
That sounds sane, although with just two flag values I'm not sure it matters.
But I guess it would document the fact that it's a bitmask, not an ordinal value, and it looks like that header is already using BIT() elsewhere so there are no new header file dependencies..
Linus
| |