lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 098/879] net: macb: In ZynqMP initialization make SGMII phy configuration optional
    Date
    From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>

    [ Upstream commit 29e96fe9e0ec0f0fe1dd306a4ccb7b8983eae67a ]

    In the macb binding documentation "phys" is an optional property. Make
    implementation in line with it. This change allows the traditional flow
    in which first stage bootloader does PS-GT configuration to work along
    with newer use cases in which PS-GT configuration is managed by the
    phy-zynqmp driver.

    It fixes below macb probe failure when macb DT node doesn't have SGMII
    phys handle.
    "macb ff0b0000.ethernet: error -ENODEV: failed to get PS-GTR PHY"

    Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
    Reviewed-by: Michal Simek <michal.simek@xilinx.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/cadence/macb_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
    index 61284baa0496..ed7c2c2c4401 100644
    --- a/drivers/net/ethernet/cadence/macb_main.c
    +++ b/drivers/net/ethernet/cadence/macb_main.c
    @@ -4594,7 +4594,7 @@ static int zynqmp_init(struct platform_device *pdev)

    if (bp->phy_interface == PHY_INTERFACE_MODE_SGMII) {
    /* Ensure PS-GTR PHY device used in SGMII mode is ready */
    - bp->sgmii_phy = devm_phy_get(&pdev->dev, "sgmii-phy");
    + bp->sgmii_phy = devm_phy_optional_get(&pdev->dev, NULL);

    if (IS_ERR(bp->sgmii_phy)) {
    ret = PTR_ERR(bp->sgmii_phy);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 00:09    [W:2.334 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site