lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 036/879] platform/x86: intel-hid: fix _DSM function index handling
    Date
    From: Michael Niewöhner <linux@mniewoehner.de>

    commit 1620c80bba53af8c547bab34a1d3bc58319fe608 upstream.

    intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
    index. Fix the function index check in intel_hid_evaluate_method
    accordingly, which was missed in commit 97ab4516205e ("platform/x86:
    intel-hid: fix _DSM function index handling").

    Fixes: 97ab4516205e ("platform/x86: intel-hid: fix _DSM function index handling")
    Cc: stable@vger.kernel.org
    Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
    Link: https://lore.kernel.org/r/66f813f5bcc724a0f6dd5adefe6a9728dbe509e3.camel@mniewoehner.de
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/platform/x86/intel/hid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/platform/x86/intel/hid.c
    +++ b/drivers/platform/x86/intel/hid.c
    @@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(ac

    method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];

    - if (!(intel_hid_dsm_fn_mask & fn_index))
    + if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
    goto skip_dsm_eval;

    obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,

    \
     
     \ /
      Last update: 2022-06-08 00:03    [W:2.604 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site