lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 771/772] md: bcache: check the return value of kzalloc() in detached_dev_do_request()
    Date
    From: Jia-Ju Bai <baijiaju1990@gmail.com>

    commit 40f567bbb3b0639d2ec7d1c6ad4b1b018f80cf19 upstream.

    The function kzalloc() in detached_dev_do_request() can fail, so its
    return value should be checked.

    Fixes: bc082a55d25c ("bcache: fix inaccurate io state for detached bcache devices")
    Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
    Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: Coly Li <colyli@suse.de>
    Link: https://lore.kernel.org/r/20220527152818.27545-4-colyli@suse.de
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/bcache/request.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/drivers/md/bcache/request.c
    +++ b/drivers/md/bcache/request.c
    @@ -1107,6 +1107,12 @@ static void detached_dev_do_request(stru
    * which would call closure_get(&dc->disk.cl)
    */
    ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);
    + if (!ddip) {
    + bio->bi_status = BLK_STS_RESOURCE;
    + bio->bi_end_io(bio);
    + return;
    + }
    +
    ddip->d = d;
    /* Count on the bcache device */
    ddip->orig_bdev = orig_bdev;

    \
     
     \ /
      Last update: 2022-06-07 23:57    [W:2.276 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site