lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 704/772] lib/string_helpers: fix not adding strarray to devices resource list
    Date
    From: Puyou Lu <puyou.lu@gmail.com>

    commit cd290a9839cee2f6641558877e707bd373c8f6f1 upstream.

    Add allocated strarray to device's resource list. This is a must to
    automatically release strarray when the device disappears.

    Without this fix we have a memory leak in the few drivers which use
    devm_kasprintf_strarray().

    Link: https://lkml.kernel.org/r/20220506044409.30066-1-puyou.lu@gmail.com
    Link: https://lkml.kernel.org/r/20220506073623.2679-1-puyou.lu@gmail.com
    Fixes: acdb89b6c87a ("lib/string_helpers: Introduce managed variant of kasprintf_strarray()")
    Signed-off-by: Puyou Lu <puyou.lu@gmail.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    lib/string_helpers.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/lib/string_helpers.c
    +++ b/lib/string_helpers.c
    @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct de
    return ERR_PTR(-ENOMEM);
    }

    + ptr->n = n;
    + devres_add(dev, ptr);
    +
    return ptr->array;
    }
    EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);

    \
     
     \ /
      Last update: 2022-06-07 23:42    [W:4.027 / U:1.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site