lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 537/772] Input: sparcspkr - fix refcount leak in bbc_beep_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit c8994b30d71d64d5dcc9bc0edbfdf367171aa96f ]

    of_find_node_by_path() calls of_find_node_opts_by_path(),
    which returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 9c1a5077fdca ("input: Rewrite sparcspkr device probing.")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220516081018.42728-1-linmq006@gmail.com
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/misc/sparcspkr.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/input/misc/sparcspkr.c b/drivers/input/misc/sparcspkr.c
    index fe43e5557ed7..cdcb7737c46a 100644
    --- a/drivers/input/misc/sparcspkr.c
    +++ b/drivers/input/misc/sparcspkr.c
    @@ -205,6 +205,7 @@ static int bbc_beep_probe(struct platform_device *op)

    info = &state->u.bbc;
    info->clock_freq = of_getintprop_default(dp, "clock-frequency", 0);
    + of_node_put(dp);
    if (!info->clock_freq)
    goto out_free;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:37    [W:2.196 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site