lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 555/772] gpio: sim: Use correct order for the parameters of devm_kcalloc()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit c680c6a814a2269427fad9ac417ab16756bceae9 ]

    We should have 'n', then 'size', not the opposite.
    This is harmless because the 2 values are just multiplied, but having
    the correct order silence a (unpublished yet) smatch warning.

    Fixes: cb8c474e79be ("gpio: sim: new testing module")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/gpio-sim.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
    index 41c31b10ae84..98109839102f 100644
    --- a/drivers/gpio/gpio-sim.c
    +++ b/drivers/gpio/gpio-sim.c
    @@ -314,8 +314,8 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)

    for (i = 0; i < num_lines; i++) {
    attr_group = devm_kzalloc(dev, sizeof(*attr_group), GFP_KERNEL);
    - attrs = devm_kcalloc(dev, sizeof(*attrs),
    - GPIO_SIM_NUM_ATTRS, GFP_KERNEL);
    + attrs = devm_kcalloc(dev, GPIO_SIM_NUM_ATTRS, sizeof(*attrs),
    + GFP_KERNEL);
    val_attr = devm_kzalloc(dev, sizeof(*val_attr), GFP_KERNEL);
    pull_attr = devm_kzalloc(dev, sizeof(*pull_attr), GFP_KERNEL);
    if (!attr_group || !attrs || !val_attr || !pull_attr)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:28    [W:2.443 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site