lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 544/772] mailbox: pcc: Fix an invalid-load caught by the address sanitizer
    Date
    From: Mario Limonciello <mario.limonciello@amd.com>

    [ Upstream commit 369e4ef87a8f5da7c348ec2c61ec5cd726e8337a ]

    `pcc_mailbox_probe` doesn't initialize all memory that has been allocated
    before the first time that one of it's members `txdone_irq` may be
    accessed.

    This leads to a an invalid load any time that this member is accessed:
    [ 2.429769] UBSAN: invalid-load in drivers/mailbox/pcc.c:684:22
    [ 2.430324] UBSAN: invalid-load in drivers/mailbox/mailbox.c:486:12
    [ 4.276782] UBSAN: invalid-load in drivers/acpi/cppc_acpi.c:314:45

    Link: https://bugzilla.kernel.org/show_bug.cgi?id=215587
    Fixes: ce028702ddbc ("mailbox: pcc: Move bulk of PCCT parsing into pcc_mbox_probe")
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mailbox/pcc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
    index ed18936b8ce6..ebfa33a40fce 100644
    --- a/drivers/mailbox/pcc.c
    +++ b/drivers/mailbox/pcc.c
    @@ -654,7 +654,7 @@ static int pcc_mbox_probe(struct platform_device *pdev)
    goto err;
    }

    - pcc_mbox_ctrl = devm_kmalloc(dev, sizeof(*pcc_mbox_ctrl), GFP_KERNEL);
    + pcc_mbox_ctrl = devm_kzalloc(dev, sizeof(*pcc_mbox_ctrl), GFP_KERNEL);
    if (!pcc_mbox_ctrl) {
    rc = -ENOMEM;
    goto err;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:28    [W:4.016 / U:1.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site