lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 3/4] mfd: intel-m10-bmc: add PMCI driver
Hi Tianfei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on v5.19-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Tianfei-Zhang/mfd-add-PMCI-driver-support/20220607-113619
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220608/202206080218.qhislJf4-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/88995bb5653b69e780baba37b6ade01348054135
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Tianfei-Zhang/mfd-add-PMCI-driver-support/20220607-113619
git checkout 88995bb5653b69e780baba37b6ade01348054135
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/mfd/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

drivers/mfd/intel-m10-bmc-pmci.c: In function 'pmci_probe':
>> drivers/mfd/intel-m10-bmc-pmci.c:58:17: error: implicit declaration of function 'devm_regmap_init_indirect_register' [-Werror=implicit-function-declaration]
58 | devm_regmap_init_indirect_register(dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/intel-m10-bmc-pmci.c:57:29: warning: assignment to 'struct regmap *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
57 | pmci->m10bmc.regmap =
| ^
cc1: some warnings being treated as errors


vim +/devm_regmap_init_indirect_register +58 drivers/mfd/intel-m10-bmc-pmci.c

39
40 static int pmci_probe(struct dfl_device *ddev)
41 {
42 struct device *dev = &ddev->dev;
43 struct pmci_device *pmci;
44
45 pmci = devm_kzalloc(dev, sizeof(*pmci), GFP_KERNEL);
46 if (!pmci)
47 return -ENOMEM;
48
49 pmci->m10bmc.dev = dev;
50 pmci->dev = dev;
51 pmci->m10bmc.type = M10_N6000;
52
53 pmci->base = devm_ioremap_resource(dev, &ddev->mmio_res);
54 if (IS_ERR(pmci->base))
55 return PTR_ERR(pmci->base);
56
> 57 pmci->m10bmc.regmap =
> 58 devm_regmap_init_indirect_register(dev,
59 pmci->base + M10BMC_PMCI_INDIRECT_BASE,
60 &m10bmc_pmci_regmap_config);
61 if (IS_ERR(pmci->m10bmc.regmap))
62 return PTR_ERR(pmci->m10bmc.regmap);
63
64 return m10bmc_dev_init(&pmci->m10bmc);
65 }
66

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-06-07 23:28    [W:0.094 / U:5.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site