lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 526/772] PCI: mediatek-gen3: Assert resets to ensure expected init state
    Date
    From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

    [ Upstream commit 1d565935e3b9ccc682631e0bc6e415a7f48295d9 ]

    The controller may have been left out of reset by the bootloader,
    in which case, before the powerup sequence, the controller will be
    found preconfigured with values that were set before booting the
    kernel: this produces a controller failure, with the result of
    a failure during the mtk_pcie_startup_port() sequence as the PCIe
    link never gets up.

    To ensure that we get a clean start in an expected state, assert
    both the PHY and MAC resets before executing the controller
    power-up sequence.

    Link: https://lore.kernel.org/r/20220404144858.92390-1-angelogioacchino.delregno@collabora.com
    Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
    Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
    index 7705d61fba4c..0e27a49ae0c2 100644
    --- a/drivers/pci/controller/pcie-mediatek-gen3.c
    +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
    @@ -838,6 +838,14 @@ static int mtk_pcie_setup(struct mtk_gen3_pcie *pcie)
    if (err)
    return err;

    + /*
    + * The controller may have been left out of reset by the bootloader
    + * so make sure that we get a clean start by asserting resets here.
    + */
    + reset_control_assert(pcie->phy_reset);
    + reset_control_assert(pcie->mac_reset);
    + usleep_range(10, 20);
    +
    /* Don't touch the hardware registers before power up */
    err = mtk_pcie_power_up(pcie);
    if (err)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:28    [W:2.159 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site