lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 505/772] drivers/base/node.c: fix compaction sysfs file leak
    Date
    From: Miaohe Lin <linmiaohe@huawei.com>

    [ Upstream commit da63dc84befaa9e6079a0bc363ff0eaa975f9073 ]

    Compaction sysfs file is created via compaction_register_node in
    register_node. But we forgot to remove it in unregister_node. Thus
    compaction sysfs file is leaked. Using compaction_unregister_node to fix
    this issue.

    Link: https://lkml.kernel.org/r/20220401070905.43679-1-linmiaohe@huawei.com
    Fixes: ed4a6d7f0676 ("mm: compaction: add /sys trigger for per-node memory compaction")
    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Rafael J. Wysocki <rafael@kernel.org>
    Cc: Mel Gorman <mel@csn.ul.ie>
    Cc: Minchan Kim <minchan.kim@gmail.com>
    Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/base/node.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/base/node.c b/drivers/base/node.c
    index 87acc47e8951..7b8368bc2000 100644
    --- a/drivers/base/node.c
    +++ b/drivers/base/node.c
    @@ -682,6 +682,7 @@ static int register_node(struct node *node, int num)
    */
    void unregister_node(struct node *node)
    {
    + compaction_unregister_node(node);
    hugetlb_unregister_node(node); /* no-op, if memoryless node */
    node_remove_accesses(node);
    node_remove_caches(node);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:23    [W:3.459 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site