lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 389/772] io_uring: avoid io-wq -EAGAIN looping for !IOPOLL
    Date
    From: Pavel Begunkov <asml.silence@gmail.com>

    [ Upstream commit e0deb6a025ae8c850dc8685be39fb27b06c88736 ]

    If an opcode handler semi-reliably returns -EAGAIN, io_wq_submit_work()
    might continue busily hammer the same handler over and over again, which
    is not ideal. The -EAGAIN handling in question was put there only for
    IOPOLL, so restrict it to IOPOLL mode only where there is no other
    recourse than to retry as we cannot wait.

    Fixes: def596e9557c9 ("io_uring: support for IO polling")
    Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
    Link: https://lore.kernel.org/r/f168b4f24181942f3614dd8ff648221736f572e6.1652433740.git.asml.silence@gmail.com
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/io_uring.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/io_uring.c b/fs/io_uring.c
    index a0680046ff3c..26bf488096b2 100644
    --- a/fs/io_uring.c
    +++ b/fs/io_uring.c
    @@ -6939,6 +6939,8 @@ static void io_wq_submit_work(struct io_wq_work *work)
    * wait for request slots on the block side.
    */
    if (!needs_poll) {
    + if (!(req->ctx->flags & IORING_SETUP_IOPOLL))
    + break;
    cond_resched();
    continue;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:15    [W:3.273 / U:0.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site