lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 399/772] net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init
    Date
    From: Zheng Bin <zhengbin13@huawei.com>

    [ Upstream commit 382d917bfc1e92339dae3c8a636b2730e8bb5132 ]

    hinic_pf_to_mgmt_init misses destroy_workqueue in error path,
    this patch fixes that.

    Fixes: 6dbb89014dc3 ("hinic: fix sending mailbox timeout in aeq event work")
    Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
    index ebc77771f5da..4aa1f433ed24 100644
    --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
    +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
    @@ -643,6 +643,7 @@ int hinic_pf_to_mgmt_init(struct hinic_pf_to_mgmt *pf_to_mgmt,
    err = alloc_msg_buf(pf_to_mgmt);
    if (err) {
    dev_err(&pdev->dev, "Failed to allocate msg buffers\n");
    + destroy_workqueue(pf_to_mgmt->workq);
    hinic_health_reporters_destroy(hwdev->devlink_dev);
    return err;
    }
    @@ -650,6 +651,7 @@ int hinic_pf_to_mgmt_init(struct hinic_pf_to_mgmt *pf_to_mgmt,
    err = hinic_api_cmd_init(pf_to_mgmt->cmd_chain, hwif);
    if (err) {
    dev_err(&pdev->dev, "Failed to initialize cmd chains\n");
    + destroy_workqueue(pf_to_mgmt->workq);
    hinic_health_reporters_destroy(hwdev->devlink_dev);
    return err;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:12    [W:3.020 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site