lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 360/772] PM: EM: Decrement policy counter
    Date
    From: Pierre Gondois <Pierre.Gondois@arm.com>

    [ Upstream commit c9d8923bfbcb63f15ea6cb2b5c8426fc3d96f643 ]

    In commit e458716a92b57 ("PM: EM: Mark inefficiencies in CPUFreq"),
    cpufreq_cpu_get() is called without a cpufreq_cpu_put(), permanently
    increasing the reference counts of the policy struct.

    Decrement the reference count once the policy struct is not used
    anymore.

    Fixes: e458716a92b57 ("PM: EM: Mark inefficiencies in CPUFreq")
    Tested-by: Cristian Marussi <cristian.marussi@arm.com>
    Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
    Reviewed-by: Vincent Donnefort <vincent.donnefort@arm.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/power/energy_model.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
    index 0153b0ca7b23..6219aaa454b5 100644
    --- a/kernel/power/energy_model.c
    +++ b/kernel/power/energy_model.c
    @@ -259,6 +259,8 @@ static void em_cpufreq_update_efficiencies(struct device *dev)
    found++;
    }

    + cpufreq_cpu_put(policy);
    +
    if (!found)
    return;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:07    [W:3.041 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site