lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 362/772] ASoC: samsung: Fix refcount leak in aries_audio_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit bf4a9b2467b775717d0e9034ad916888e19713a3 ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    If extcon_find_edev_by_node() fails, it doesn't call of_node_put()
    Calling of_node_put() after extcon_find_edev_by_node() to fix this.

    Fixes: 7a3a7671fa6c ("ASoC: samsung: Add driver for Aries boards")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/20220512043828.496-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/samsung/aries_wm8994.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8994.c
    index 5265e546b124..83acbe57b248 100644
    --- a/sound/soc/samsung/aries_wm8994.c
    +++ b/sound/soc/samsung/aries_wm8994.c
    @@ -585,10 +585,10 @@ static int aries_audio_probe(struct platform_device *pdev)

    extcon_np = of_parse_phandle(np, "extcon", 0);
    priv->usb_extcon = extcon_find_edev_by_node(extcon_np);
    + of_node_put(extcon_np);
    if (IS_ERR(priv->usb_extcon))
    return dev_err_probe(dev, PTR_ERR(priv->usb_extcon),
    "Failed to get extcon device");
    - of_node_put(extcon_np);

    priv->adc = devm_iio_channel_get(dev, "headset-detect");
    if (IS_ERR(priv->adc))
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:07    [W:3.887 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site