lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 301/772] scsi: iscsi: Fix harmless double shift bug
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 565138ac5f8a5330669a20e5f94759764e9165ec ]

    These flags are supposed to be bit numbers. Right now they cause a double
    shift bug where we use BIT(BIT(2)) instead of BIT(2). Fortunately, the bit
    numbers are small and it's done consistently so it does not cause an issue
    at run time.

    Link: https://lore.kernel.org/r/YmFyWHf8nrrx+SHa@kili
    Fixes: 5bd856256f8c ("scsi: iscsi: Merge suspend fields")
    Reviewed-by: Mike Christie <michael.christie@oracle.com>
    Reviewed-by: Lee Duncan <lduncan@suse.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/scsi/libiscsi.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/include/scsi/libiscsi.h b/include/scsi/libiscsi.h
    index d1e282f0d6f1..6ad01d7de480 100644
    --- a/include/scsi/libiscsi.h
    +++ b/include/scsi/libiscsi.h
    @@ -53,9 +53,9 @@ enum {
    #define ISID_SIZE 6

    /* Connection flags */
    -#define ISCSI_CONN_FLAG_SUSPEND_TX BIT(0)
    -#define ISCSI_CONN_FLAG_SUSPEND_RX BIT(1)
    -#define ISCSI_CONN_FLAG_BOUND BIT(2)
    +#define ISCSI_CONN_FLAG_SUSPEND_TX 0
    +#define ISCSI_CONN_FLAG_SUSPEND_RX 1
    +#define ISCSI_CONN_FLAG_BOUND 2

    #define ISCSI_ITT_MASK 0x1fff
    #define ISCSI_TOTAL_CMDS_MAX 4096
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:07    [W:4.037 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site