lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 316/772] drm/msm/dp: fix error check return value of irq_of_parse_and_map()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit e92d0d93f86699b7b25c7906613fdc374d66c8ca ]

    The irq_of_parse_and_map() function returns 0 on failure, and does not
    return an negative value.

    Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets")
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Patchwork: https://patchwork.freedesktop.org/patch/483176/
    Link: https://lore.kernel.org/r/20220424032418.3173632-1-lv.ruyi@zte.com.cn
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/dp/dp_display.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
    index 229c699f6227..fb424f8b29e5 100644
    --- a/drivers/gpu/drm/msm/dp/dp_display.c
    +++ b/drivers/gpu/drm/msm/dp/dp_display.c
    @@ -1212,10 +1212,9 @@ int dp_display_request_irq(struct msm_dp *dp_display)
    dp = container_of(dp_display, struct dp_display_private, dp_display);

    dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0);
    - if (dp->irq < 0) {
    - rc = dp->irq;
    - DRM_ERROR("failed to get irq: %d\n", rc);
    - return rc;
    + if (!dp->irq) {
    + DRM_ERROR("failed to get irq\n");
    + return -EINVAL;
    }

    rc = devm_request_irq(&dp->pdev->dev, dp->irq,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:03    [W:2.056 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site