lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 320/772] drm/msm/hdmi: check return value after calling platform_get_resource_byname()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit a36e506711548df923ceb7ec9f6001375be799a5 ]

    It will cause null-ptr-deref if platform_get_resource_byname() returns NULL,
    we need check the return value.

    Fixes: c6a57a50ad56 ("drm/msm/hdmi: add hdmi hdcp support (V3)")
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Patchwork: https://patchwork.freedesktop.org/patch/482992/
    Link: https://lore.kernel.org/r/20220422032227.2991553-1-yangyingliang@huawei.com
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/hdmi/hdmi.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
    index 719720709e9e..d3fea6ec5246 100644
    --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
    +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
    @@ -142,6 +142,10 @@ static struct hdmi *msm_hdmi_init(struct platform_device *pdev)
    /* HDCP needs physical address of hdmi register */
    res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
    config->mmio_name);
    + if (!res) {
    + ret = -EINVAL;
    + goto fail;
    + }
    hdmi->mmio_phy_addr = res->start;

    hdmi->qfprom_mmio = msm_ioremap(pdev,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:03    [W:2.029 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site