lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 260/772] scftorture: Fix distribution of short handler delays
    Date
    From: Paul E. McKenney <paulmck@kernel.org>

    [ Upstream commit 8106bddbab5f0ba180e6d693c7c1fc6926d57caa ]

    The scftorture test module's scf_handler() function is supposed to provide
    three different distributions of short delays (including "no delay") and
    one distribution of long delays, if specified by the scftorture.longwait
    module parameter. However, the second of the two non-zero-wait short delays
    is disabled due to the first such delay's "goto out" not being enclosed in
    the "then" clause with the "udelay()".

    This commit therefore adjusts the code to provide the intended set of
    delays.

    Fixes: e9d338a0b179 ("scftorture: Add smp_call_function() torture test")
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/scftorture.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/kernel/scftorture.c b/kernel/scftorture.c
    index dcb0410950e4..5d113aa59e77 100644
    --- a/kernel/scftorture.c
    +++ b/kernel/scftorture.c
    @@ -267,9 +267,10 @@ static void scf_handler(void *scfc_in)
    }
    this_cpu_inc(scf_invoked_count);
    if (longwait <= 0) {
    - if (!(r & 0xffc0))
    + if (!(r & 0xffc0)) {
    udelay(r & 0x3f);
    - goto out;
    + goto out;
    + }
    }
    if (r & 0xfff)
    goto out;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 23:03    [W:4.127 / U:1.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site