lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 219/772] powerpc/iommu: Add missing of_node_put in iommu_init_early_dart
    Date
    From: Peng Wu <wupeng58@huawei.com>

    [ Upstream commit 57b742a5b8945118022973e6416b71351df512fb ]

    The device_node pointer is returned by of_find_compatible_node
    with refcount incremented. We should use of_node_put() to avoid
    the refcount leak.

    Signed-off-by: Peng Wu <wupeng58@huawei.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220425081245.21705-1-wupeng58@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/sysdev/dart_iommu.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/arch/powerpc/sysdev/dart_iommu.c b/arch/powerpc/sysdev/dart_iommu.c
    index be6b99b1b352..9a02aed886a0 100644
    --- a/arch/powerpc/sysdev/dart_iommu.c
    +++ b/arch/powerpc/sysdev/dart_iommu.c
    @@ -404,9 +404,10 @@ void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)
    }

    /* Initialize the DART HW */
    - if (dart_init(dn) != 0)
    + if (dart_init(dn) != 0) {
    + of_node_put(dn);
    return;
    -
    + }
    /*
    * U4 supports a DART bypass, we use it for 64-bit capable devices to
    * improve performance. However, that only works for devices connected
    @@ -419,6 +420,7 @@ void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)

    /* Setup pci_dma ops */
    set_pci_dma_ops(&dma_iommu_ops);
    + of_node_put(dn);
    }

    #ifdef CONFIG_PM
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 22:59    [W:2.109 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site