lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 262/772] ixp4xx_eth: fix error check return value of platform_get_irq()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit f45ba67eb74ab4b775616af731bdf8944afce3f1 ]

    platform_get_irq() return negative value on failure, so null check of
    return value is incorrect. Fix it by comparing whether it is less than
    zero.

    Fixes: 9055a2f59162 ("ixp4xx_eth: make ptp support a platform driver")
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://lore.kernel.org/r/20220412085126.2532924-1-lv.ruyi@zte.com.cn
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/xscale/ptp_ixp46x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/xscale/ptp_ixp46x.c b/drivers/net/ethernet/xscale/ptp_ixp46x.c
    index 39234852e01b..20f6aa508003 100644
    --- a/drivers/net/ethernet/xscale/ptp_ixp46x.c
    +++ b/drivers/net/ethernet/xscale/ptp_ixp46x.c
    @@ -272,7 +272,7 @@ static int ptp_ixp_probe(struct platform_device *pdev)
    ixp_clock.master_irq = platform_get_irq(pdev, 0);
    ixp_clock.slave_irq = platform_get_irq(pdev, 1);
    if (IS_ERR(ixp_clock.regs) ||
    - !ixp_clock.master_irq || !ixp_clock.slave_irq)
    + ixp_clock.master_irq < 0 || ixp_clock.slave_irq < 0)
    return -ENXIO;

    ixp_clock.caps = ptp_ixp_caps;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 22:58    [W:4.594 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site