lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 280/772] spi: img-spfi: Fix pm_runtime_get_sync() error checking
    Date
    From: Zheng Yongjun <zhengyongjun3@huawei.com>

    [ Upstream commit cc470d55343056d6b2a5c32e10e0aad06f324078 ]

    If the device is already in a runtime PM enabled state
    pm_runtime_get_sync() will return 1, so a test for negative
    value should be used to check for errors.

    Fixes: deba25800a12b ("spi: Add driver for IMG SPFI controller")
    Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
    Link: https://lore.kernel.org/r/20220422062641.10486-1-zhengyongjun3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-img-spfi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c
    index 5f05d519fbbd..71376b6df89d 100644
    --- a/drivers/spi/spi-img-spfi.c
    +++ b/drivers/spi/spi-img-spfi.c
    @@ -731,7 +731,7 @@ static int img_spfi_resume(struct device *dev)
    int ret;

    ret = pm_runtime_get_sync(dev);
    - if (ret) {
    + if (ret < 0) {
    pm_runtime_put_noidle(dev);
    return ret;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 22:57    [W:4.285 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site