lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 193/772] soc: ti: ti_sci_pm_domains: Check for null return of devm_kcalloc
    Date
    From: QintaoShen <unSimple1993@163.com>

    [ Upstream commit ba56291e297d28aa6eb82c5c1964fae2d7594746 ]

    The allocation funciton devm_kcalloc may fail and return a null pointer,
    which would cause a null-pointer dereference later.
    It might be better to check it and directly return -ENOMEM just like the
    usage of devm_kcalloc in previous code.

    Signed-off-by: QintaoShen <unSimple1993@163.com>
    Signed-off-by: Nishanth Menon <nm@ti.com>
    Link: https://lore.kernel.org/r/1648107843-29077-1-git-send-email-unSimple1993@163.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/ti/ti_sci_pm_domains.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c
    index 8afb3f45d263..a33ec7eaf23d 100644
    --- a/drivers/soc/ti/ti_sci_pm_domains.c
    +++ b/drivers/soc/ti/ti_sci_pm_domains.c
    @@ -183,6 +183,8 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
    devm_kcalloc(dev, max_id + 1,
    sizeof(*pd_provider->data.domains),
    GFP_KERNEL);
    + if (!pd_provider->data.domains)
    + return -ENOMEM;

    pd_provider->data.num_domains = max_id + 1;
    pd_provider->data.xlate = ti_sci_pd_xlate;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 22:48    [W:4.039 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site