lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 049/772] btrfs: zoned: fix comparison of alloc_offset vs meta_write_pointer
    Date
    From: Naohiro Aota <naohiro.aota@wdc.com>

    commit aa9ffadfcae33e611d8c2d476bcc2aa0d273b587 upstream.

    The block_group->alloc_offset is an offset from the start of the block
    group. OTOH, the ->meta_write_pointer is an address in the logical
    space. So, we should compare the alloc_offset shifted with the
    block_group->start.

    Fixes: afba2bc036b0 ("btrfs: zoned: implement active zone tracking")
    CC: stable@vger.kernel.org # 5.16+
    Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/zoned.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/zoned.c
    +++ b/fs/btrfs/zoned.c
    @@ -1863,7 +1863,7 @@ int btrfs_zone_finish(struct btrfs_block
    /* Check if we have unwritten allocated space */
    if ((block_group->flags &
    (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_SYSTEM)) &&
    - block_group->alloc_offset > block_group->meta_write_pointer) {
    + block_group->start + block_group->alloc_offset > block_group->meta_write_pointer) {
    spin_unlock(&block_group->lock);
    return -EAGAIN;
    }

    \
     
     \ /
      Last update: 2022-06-07 22:23    [W:4.044 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site