lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 025/772] fs/ntfs3: Fix some memory leaks in an error handling path of log_replay()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit e589f9b7078e1c0191613cd736f598e81d2390de upstream.

    All error handling paths lead to 'out' where many resources are freed.

    Do it as well here instead of a direct return, otherwise 'log', 'ra' and
    'log->one_page_buf' (at least) will leak.

    Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ntfs3/fslog.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/fs/ntfs3/fslog.c
    +++ b/fs/ntfs3/fslog.c
    @@ -4085,8 +4085,10 @@ process_log:
    if (client == LFS_NO_CLIENT_LE) {
    /* Insert "NTFS" client LogFile. */
    client = ra->client_idx[0];
    - if (client == LFS_NO_CLIENT_LE)
    - return -EINVAL;
    + if (client == LFS_NO_CLIENT_LE) {
    + err = -EINVAL;
    + goto out;
    + }

    t16 = le16_to_cpu(client);
    cr = ca + t16;

    \
     
     \ /
      Last update: 2022-06-07 22:22    [W:3.665 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site