lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 554/667] PCI/PM: Fix bridge_d3_blacklist[] Elo i2 overwrite of Gigabyte X299
    Date
    From: Bjorn Helgaas <bhelgaas@google.com>

    commit 12068bb346db5776d0ec9bb4cd073f8427a1ac92 upstream.

    92597f97a40b ("PCI/PM: Avoid putting Elo i2 PCIe Ports in D3cold") omitted
    braces around the new Elo i2 entry, so it overwrote the existing Gigabyte
    X299 entry. Add the appropriate braces.

    Found by:

    $ make W=1 drivers/pci/pci.o
    CC drivers/pci/pci.o
    drivers/pci/pci.c:2974:12: error: initialized field overwritten [-Werror=override-init]
    2974 | .ident = "Elo i2",
    | ^~~~~~~~

    Link: https://lore.kernel.org/r/20220526221258.GA409855@bhelgaas
    Fixes: 92597f97a40b ("PCI/PM: Avoid putting Elo i2 PCIe Ports in D3cold")
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Cc: stable@vger.kernel.org # v5.15+
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pci/pci.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/pci/pci.c
    +++ b/drivers/pci/pci.c
    @@ -2888,6 +2888,8 @@ static const struct dmi_system_id bridge
    DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
    DMI_MATCH(DMI_BOARD_NAME, "X299 DESIGNARE EX-CF"),
    },
    + },
    + {
    /*
    * Downstream device is not accessible after putting a root port
    * into D3cold and back into D0 on Elo i2.

    \
     
     \ /
      Last update: 2022-06-07 22:03    [W:4.046 / U:1.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site