lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 458/667] hugetlbfs: fix hugetlbfs_statfs() locking
    Date
    From: Mina Almasry <almasrymina@google.com>

    [ Upstream commit 4b25f030ae69ba710eff587cabb4c57cb7e7a8a1 ]

    After commit db71ef79b59b ("hugetlb: make free_huge_page irq safe"), the
    subpool lock should be locked with spin_lock_irq() and all call sites was
    modified as such, except for the ones in hugetlbfs_statfs().

    Link: https://lkml.kernel.org/r/20220429202207.3045-1-almasrymina@google.com
    Fixes: db71ef79b59b ("hugetlb: make free_huge_page irq safe")
    Signed-off-by: Mina Almasry <almasrymina@google.com>
    Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/hugetlbfs/inode.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
    index bb0651a4a128..d74a49b188c2 100644
    --- a/fs/hugetlbfs/inode.c
    +++ b/fs/hugetlbfs/inode.c
    @@ -1048,12 +1048,12 @@ static int hugetlbfs_statfs(struct dentry *dentry, struct kstatfs *buf)
    if (sbinfo->spool) {
    long free_pages;

    - spin_lock(&sbinfo->spool->lock);
    + spin_lock_irq(&sbinfo->spool->lock);
    buf->f_blocks = sbinfo->spool->max_hpages;
    free_pages = sbinfo->spool->max_hpages
    - sbinfo->spool->used_hpages;
    buf->f_bavail = buf->f_bfree = free_pages;
    - spin_unlock(&sbinfo->spool->lock);
    + spin_unlock_irq(&sbinfo->spool->lock);
    buf->f_files = sbinfo->max_inodes;
    buf->f_ffree = sbinfo->free_inodes;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 21:55    [W:3.997 / U:0.896 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site